search

astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
329 stars 40 forks source link

Adjust test for Airflow-2.9 #2149

Closed pankajastro closed 1 month ago

pankajastro commented 1 month ago
pankajastro commented 1 month ago

pre-commit failure is looking like because of recent pre-commit hook update will handle that in separate PR

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.12%. Comparing base (162b0ab) to head (aea0ff6). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2149 +/- ## ========================================== + Coverage 89.75% 91.12% +1.37% ========================================== Files 75 75 Lines 4322 4316 -6 Branches 539 538 -1 ========================================== + Hits 3879 3933 +54 + Misses 343 287 -56 + Partials 100 96 -4 ``` | [Flag](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2149/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | Coverage Δ | | |---|---|---| | [PythonSDK](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | `91.12% <100.00%> (+1.37%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaxil commented 1 month ago

Why this in review state since 5 days?

pankajastro commented 1 month ago

Why this in review state since 5 days?

Will connect with the codeowners to conclude on this.

pankajastro commented 1 month ago

some tests are failing because of Databricks related infra change

pankajastro commented 1 month ago

some tests are failing because of Databricks related infra change

Fixed in PR https://github.com/astronomer/astro-sdk/pull/2161 and https://github.com/astronomer/astro-sdk/pull/2159