astronomer / astronomer-airflow-version-check

Plugin to check if new version of Astronomer Certified Airflow is available
Apache License 2.0
1 stars 2 forks source link

v1 of the plugin #1

Closed ashb closed 4 years ago

ashb commented 4 years ago

This plugin operates as follows:

ashb commented 4 years ago

Screenshots of what this looks like in the UI:

image

image

The "Ignore this update" will only be visible to admins right now (technically anyone with the "can_dismiss on UpdateAvailableView" permission - which admins get automatically)

andriisoldatenko commented 4 years ago

@ashb in general LGTM, tests would be nice to have :)

ashb commented 4 years ago

Now with bearest of minimal tests.

(Checks that the plugin loads, and that the template hackery I've added has worked)

Need to add some tests against the HTTP checker part then this is done.

ashb commented 4 years ago

~Oh and I need to change that message.~

ashb commented 4 years ago

The unit tests should probably be extneded, but good enough for now.