search

astronomer / astronomer-airflow-version-check

Plugin to check if new version of Astronomer Certified Airflow is available
Apache License 2.0
1 stars 2 forks source link

Repeat 'venv' creation in publish job #32

Closed ephraimbuddy closed 2 years ago

ephraimbuddy commented 2 years ago

The restoring of virtualenv doesn't work in this alpine image in publish job

blag commented 2 years ago

Through a series of symlinks, the Python3 executable from .venv is pointing at a nonexistent virtualenv created by PyEnv.

Removing the save to/restore from cache for the .venv directory might help get us a fresh virtualenv each time. With as few dependencies as this project seems to have, I'm not sure that the time saved via caching is worth the effort of debugging and maintaining it.

ephraimbuddy commented 2 years ago

Through a series of symlinks, the Python3 executable from .venv is pointing at a nonexistent virtualenv created by PyEnv.

Removing the save to/restore from cache for the .venv directory might help get us a fresh virtualenv each time. With as few dependencies as this project seems to have, I'm not sure that the time saved via caching is worth the effort of debugging and maintaining it.

I added the verify step as a separate job. I think that's better. The publish step has to depend on the verify step.

ashb commented 2 years ago

I don't understand why this change is needed?

From a workflow point of view, verifying the tag is a step in publishing, not a whole separate job though.

ephraimbuddy commented 2 years ago

I don't understand why this change is needed?

From a workflow point of view, verifying the tag is a step in publishing, not a whole separate job though.

Ok. I will go back to the publish step. The issue was that I and @Drew have tried several things on the publish step container. The restored virtualenv doesn't work and installing a new environment also gives issues.

ephraimbuddy commented 2 years ago

This worked in my test https://app.circleci.com/pipelines/github/astronomer/astronomer-airflow-version-check/229/workflows/07727e83-5b2c-4dfc-8adf-8eef5e1de513/jobs/306. It ran the verify and failed because there's no git tag which is fine because there's none