Fix bug in ignoring new version available update banner

astronomer / astronomer-airflow-version-check

Plugin to check if new version of Astronomer Certified Airflow is available

Apache License 2.0

1 stars 2 forks source link

Closed ephraimbuddy closed 1 year ago

ephraimbuddy commented 1 year ago

Tested this manually as I was unable to do unittest on it

jedcunningham commented 1 year ago

Any idea how the admin role got can_dismiss though? Having trouble tracing that back.

ashb commented 1 year ago

Oh, admin gets all permissions aged by FAB at start up

ephraimbuddy commented 1 year ago

Any idea how the admin role got can_dismiss though? Having trouble tracing that back.

From FAB, there's a PERMISSIONPREFIX='can' and then the method name of the endpoint 'dismiss'

ephraimbuddy commented 1 year ago

I think we only allowed admins to dismiss the notice. Is that still kept?

Nope. Have changed it to (permissions.ACTION_CAN_READ, permissions.RESOURCE_ROLE). Only Admins have that permission in Airflow