search

astronomer / astronomer-cosmos

Run your dbt Core projects as Apache Airflow DAGs and Task Groups with a few lines of code
https://astronomer.github.io/astronomer-cosmos/
Apache License 2.0
596 stars 152 forks source link

Render DBT Docs #571

Closed fritz-astronomer closed 7 months ago

fritz-astronomer commented 11 months ago

https://apache-airflow.slack.com/archives/C059CC42E9W/p1696010143212889?thread_ts=1695509325.058599&cid=C059CC42E9W

It was requested to have a link to dbt docs, such as are rendered with 

dbt docs generate
dbt docs serve

@chrishronek mentioned that these could be generated and served statically. I commented that Airflow can serve static files with a plugin (which could maybe be shipped with cosmos?)

fritz-astronomer commented 11 months ago

https://github.com/astronomer/astronomer-cosmos/blob/main/cosmos/operators/local.py#L541 This could suffice as an alternative

dosubot[bot] commented 7 months ago

Hi, @fritz-astronomer,

I'm helping the Cosmos team manage our backlog and am marking this issue as stale. From what I understand, the issue was opened as a request to render DBT documentation, with discussions around generating and serving the documentation statically, as well as the suggestion of using an Airflow plugin to serve static files. There's also a potential alternative solution provided by you.

Could you please confirm if this issue is still relevant to the latest version of the Cosmos repository? If it is, please let the Cosmos team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your understanding and assistance in keeping the repository's issue tracker organized.

Dosu

fritz-astronomer commented 7 months ago

begone, robot

fritz-astronomer commented 7 months ago

@tatiana is there a way to remove the stale label? Looks like there is an open PR. I can't change any labels or assignees

dosubot[bot] commented 7 months ago

🤖

Hi @fritz-astronomer,

Thank you for your response. We appreciate your engagement. We'll go ahead and close this issue now. If you have any further questions or need assistance, feel free to open a new issue.

Thanks again!

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

fritz-astronomer commented 7 months ago

I hate this robot already 😞

devstein commented 7 months ago

Hey @fritz-astronomer apologies for this! Dosu shouldn't have closed the issue after you comment.

What would have been the ideal behavior? Should Dosu have tagged a maintainer to look at the open PR? Any feedback is helpful!

fritz-astronomer commented 7 months ago

@devstein - there is an open PR, so the issue isn't stale and shouldn't've been flagged as such. Additionally I have no way to remove the stale label myself (which is a project configuration issue 🤷 ) and no way to tell the robot to remove the stale label (at least not an obvious one)

dosubot[bot] commented 7 months ago

🤖

This situation seems to need your attention, @tatiana, could you please step in and provide your expertise?

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

devstein commented 7 months ago

@fritz-astronomer Helpful feedback, thank you! To have Dosu remove the stale label you tell it that the issue isn't stale, but agree we can do a better job of communicating this.