search

astronomer / astronomer-providers

Airflow Providers containing Deferrable Operators & Sensors from Astronomer
https://astronomer-providers.rtfd.io/
Apache License 2.0
128 stars 25 forks source link

Pass `parameters` to parent class in SnowflakeSensorAsync #1519

Closed josh-fell closed 1 month ago

josh-fell commented 2 months ago

Currently the SnowflakeSensorAsync does not propagate parameters to its parent class, SqlSensor. Because of this, parameters are not passed for execution and can cause task failures when attempting doing so.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.33%. Comparing base (d74cf30) to head (d11a483).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1519 +/- ## ======================================= Coverage 98.33% 98.33% ======================================= Files 94 94 Lines 4636 4636 ======================================= Hits 4559 4559 Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pankajkoti commented 2 months ago

@Lee-W perhaps we need to make a release for astronomer-providers after merging this?