search

astronomer / astronomer-providers

Airflow Providers containing Deferrable Operators & Sensors from Astronomer
https://astronomer-providers.rtfd.io/
Apache License 2.0
128 stars 25 forks source link

Fix SnowflakeSensorTrigger storing callable as string #1530

Closed pankajastro closed 1 month ago

pankajastro commented 1 month ago

closes: https://github.com/astronomer/astronomer-providers/issues/1528

When saved in the trigger kwargs, both success and failure parameters are stored as strings rather than callable functions. This PR aims to move the validation logic from trigger to operator component

Screenshot 2024-05-22 at 10 48 47 PM
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.32%. Comparing base (52c9b20) to head (76c2a72).

Files Patch % Lines
.../providers/snowflake/triggers/snowflake_trigger.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1530 +/- ## ========================================== - Coverage 98.34% 98.32% -0.02% ========================================== Files 94 94 Lines 4642 4650 +8 ========================================== + Hits 4565 4572 +7 - Misses 77 78 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pankajastro commented 1 month ago

should we add example intergration dag test for this?

Added a task PTAL