Proposal: Add a dag_only parameter

astronomer / deploy-action

Custom Github Actions

Other

19 stars 20 forks source link

Proposal: Add a dag_only parameter #64

Closed gasci closed 3 days ago

gasci commented 3 months ago

We would like to overwrite the dag_only detection on demand. Therefore, it would be great to have a dag_only parameter.

We want to run the deploy action with the dag_only option even though we change files at a non-dags folder. Currently, we are not able to prevent the full environment build image upload.

sunkickr commented 3 months ago

good idea

gasci commented 3 months ago

Thank you for the feedback. And is it possible to release a v5 after these additions? We are using this action every day and we depend on this feature to make our CI/CD pipelines more flexible.

gasci commented 3 weeks ago

Has there been any update on this feature? This feature is really crucial for our pipelines not to push the same image multiple times.

neel-astro commented 4 days ago

This is resolved as part of adding dbt deploy support in deploy-action, as we introduced a new deploy-type field, that allows users to configure a dags-only deploy if the trigger event only had file changes in the dags folder. Reference PR that solves the issue: #74

gasci commented 3 days ago

Does it forcefully dag-only deploy even though the file changes say otherwise?

neel-astro commented 3 days ago

yeah, so if the deploy-action is configured with deploy-type set as dags-only then it will have the following behavior:

When a file is updated inside the dags folder - deploy-action would do a dag-only deploy
When a non-dag file (i.e. file outside the dags folder) is updated - deploy-action will skip any form of deploy since it is configured for dag-only deploy, and in this case, there are no updates in the dags folder

Note that the change has not yet been released, so you can't use it right away, but trying to get it out soon