search

astronomy-commons / adc-streaming

Core Python(ic) client libraries and utilities for alert streaming
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Look into submitting adc-streaming for inclusion to conda-forge #27

Open mjuric opened 4 years ago

mjuric commented 4 years ago

We should look into submitting adc-streaming to conda-forge, to make it easy for downstream dependences to install.

This would require creating a feedstock from the current recipe, and understand how we'd want to manage the in-package recipe vs. having it fully in the feedstock.

myNameIsPatrick commented 3 years ago

@mjuric, @spenczar, the current method for determining the version is incompatible with a conda-forge feedstock, since it requires the package to be installed from a git repository and we need to be able to install the package from an archive.

Running command python setup.py egg_info
    fatal: not a git repository (or any of the parent directories): .git
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/tmp/pip-req-build-iqs0q977/setup.py", line 93, in <module>
        version=git_version(),
      File "/private/tmp/pip-req-build-iqs0q977/setup.py", line 32, in git_version
        version = check_output(command.split()).decode('utf-8').strip()
      File "/Users/runner/miniforge3/conda-bld/adc-streaming_1616459830588/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/subprocess.py", line 356, in check_output
        **kwargs).stdout
      File "/Users/runner/miniforge3/conda-bld/adc-streaming_1616459830588/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.6/subprocess.py", line 438, in run
        output=stdout, stderr=stderr)
    subprocess.CalledProcessError: Command '['git', 'describe', '--tags', '--long', '--dirty', '--always']' returned non-zero exit status 128.
mjuric commented 3 years ago

Hi Patrick, where is the draft feedstock code (to understand the problem better...)?

myNameIsPatrick commented 3 years ago

Here is the meta.yaml recipe: https://github.com/conda-forge/staged-recipes/pull/14349/files Here are the logs for a failed job in the PR (now closed): https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=294010&view=logs&jobId=6f142865-96c3-535c-b7ea-873d86b887bd&j=e35d4f76-8ff2-5536-d795-df91e63eb9f7&t=fa7b4b17-b6ff-5c9c-8cfc-15f888c92310

myNameIsPatrick commented 3 years ago

Re-submitted to staged-recipes: https://github.com/conda-forge/staged-recipes/pull/16369

myNameIsPatrick commented 3 years ago

Now on conda-forge: https://anaconda.org/conda-forge/adc-streaming