search

astronomy-commons / adc-streaming

Core Python(ic) client libraries and utilities for alert streaming
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Version for new release? #50

Closed myNameIsPatrick closed 3 years ago

myNameIsPatrick commented 3 years ago

@cnweaver and I would like a new release to grab some of the latest features from master. I can do the work to put out a new release, but wanted to check that this would correspond with a minor version bump or major? It's not clear to me what the API changes introduced by the work @cnweaver added and how much of this is backwards incompatible.

cnweaver commented 3 years ago

It is backwards incompatible enough to quite noticeably break code written against the old interface, unfortunately: https://github.com/scimma/hop-client/issues/158 . Whether you want to treat that as a major version change or not is mostly up to how you want to interpret the version number.

myNameIsPatrick commented 3 years ago

I have no preference personally on whether we go with 2.0.0 or 1.3.0. Following SemVer to the letter would be nice in principle. Do you have a preference for one or the other, @spenczar?

spenczar commented 3 years ago

Yes, since this is a breaking change, it should be 2.0.0, I think.