search

astronomy-commons / adc-streaming

Core Python(ic) client libraries and utilities for alert streaming
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Add pyproject.toml file for PEP 517 builds #60

Closed lpsinger closed 2 years ago

lpsinger commented 2 years ago

This file is now required for building Python packages, in the most general case.

lpsinger commented 2 years ago

This won't be sufficient, as any installations making use of pyproject.toml will skip over all the project metadata currently embedded within setup.py. All that project metadata should be migrated to setup.cfg.

No, that's not correct. Metadata in setup.py will be respected. You could migrate to declarative metadata, but you don't have to. If you did, then I would suggest migrating the contents of both setup.cfg and setup.py to pyproject.toml.

lpsinger commented 2 years ago

Please take a look again. I enabled setuptools_scm.

cnweaver commented 2 years ago

This seems fine to me, so I will proceed to merge.