Closed lpsinger closed 2 years ago
This won't be sufficient, as any installations making use of pyproject.toml will skip over all the project metadata currently embedded within setup.py. All that project metadata should be migrated to setup.cfg.
No, that's not correct. Metadata in setup.py will be respected. You could migrate to declarative metadata, but you don't have to. If you did, then I would suggest migrating the contents of both setup.cfg and setup.py to pyproject.toml.
Please take a look again. I enabled setuptools_scm.
This seems fine to me, so I will proceed to merge.
This file is now required for building Python packages, in the most general case.