search

astronomy-commons / axs

Astronomy eXtensions for Spark: Fast, Scalable, Analytics of Billion+ row catalogs
https://axs.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
23 stars 12 forks source link

histogram2d doesn't exclude out-of-bounds entries #12

Open ctslater opened 4 years ago

ctslater commented 4 years ago

If the dataframe has values outside the min1, max1, etc bounds, histogram2d will try to put these values into the output array but that will result in out-of-bounds errors.

ctslater commented 4 years ago

I've pushed a branch issue12_histogram which fixes this and switches to using integers for bins. There were some weird effects where certain columns or rows had all zeros, I'm guessing due to some rounding issues.