astronomy-commons / hats

Hierarchical Progressive Survey Catalog
https://hats.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Provide better type hints for path-like arguments. #342

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Providing better type-hints for most path-like arguments that will accept any of string, Path, or new universal pathlib UPath.

This was kinda hinted at by Kostya in review of https://github.com/astronomy-commons/hipscat/pull/336, and I should have listened then.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.05%. Comparing base (23ae2ee) to head (9dd6268). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== + Coverage 94.00% 94.05% +0.05% ========================================== Files 58 58 Lines 2117 2135 +18 ========================================== + Hits 1990 2008 +18 Misses 127 127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago
Before [23ae2eee] After [362cb2bb] Ratio Benchmark (Parameter)
87.1±2ms 92.4±1ms 1.06 benchmarks.Suite.time_paths_creation
13.4±0.4ms 13.5±0.4ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
19.8±0.4ms 19.7±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
77.3±0.4ms 76.9±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
371±3ms 371±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
42.1±0.3ms 42.1±0.5ms 1 benchmarks.Suite.time_pixel_tree_creation
113±1ms 113±0.7ms 1 benchmarks.time_test_alignment_even_sky
973±5μs 972±7μs 1 benchmarks.time_test_cone_filter_multiple_order
77.9±0.3ms 77.0±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7

Click here to view all benchmarks.