astronomy-commons / hats

Hierarchical Progressive Survey Catalog
https://hats.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Remove unused methods in pixel margin module #343

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Methods were unused by margin generation filtering code, either in import or LSDB packages.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.97%. Comparing base (efb34b6) to head (a9407cd). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #343 +/- ## ========================================== - Coverage 94.05% 93.97% -0.08% ========================================== Files 58 58 Lines 2135 2124 -11 ========================================== - Hits 2008 1996 -12 - Misses 127 128 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago
Before [efb34b65] After [11a8b2c0] Ratio Benchmark (Parameter)
372±3ms 383±8ms 1.03 benchmarks.Suite.time_outer_pixel_alignment
88.2±2ms 90.2±2ms 1.02 benchmarks.Suite.time_paths_creation
13.2±0.3ms 13.4±0.6ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
41.8±0.9ms 42.2±1ms 1.01 benchmarks.Suite.time_pixel_tree_creation
20.0±0.5ms 19.9±0.2ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
77.6±0.6ms 76.5±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
77.3±0.5ms 76.9±0.7ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
113±2ms 112±0.6ms 0.99 benchmarks.time_test_alignment_even_sky
996±20μs 961±2μs 0.96 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.