astronomy-commons / hats

Hierarchical Progressive Survey Catalog
https://hats.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Create HIPS-style properties file #358

Closed delucchi-cmu closed 3 weeks ago

delucchi-cmu commented 3 weeks ago

Change Description

This introduces a java-style properties file, similar to the properties file in the HiPS standard.

This fully replaces the catalog_info.json file, and removes the provenance info handling from this library. Individual tools will optionally write out some tool arguments file (see #351).

Closes #347, #348, #351

Related to issue #339, as the hats_builder kwarg will be used for importing tool name and date.

Working branches that work with this change:

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 3 weeks ago
Before [4357f0c9] After [83ceadf5] Ratio Benchmark (Parameter)
failed 18.9±0.3ms n/a benchmarks.MetadataSuite.time_load_partition_info_order6
failed 77.2±1ms n/a benchmarks.MetadataSuite.time_load_partition_info_order7
failed 76.7±0.7ms n/a benchmarks.MetadataSuite.time_load_partition_join_info
failed 13.5±0.2ms n/a benchmarks.Suite.time_inner_pixel_alignment
failed 393±3ms n/a benchmarks.Suite.time_outer_pixel_alignment
failed 88.9±2ms n/a benchmarks.Suite.time_paths_creation
failed 43.9±0.3ms n/a benchmarks.Suite.time_pixel_tree_creation
failed 124±0.4ms n/a benchmarks.time_test_alignment_even_sky
failed 983±3μs n/a benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (hats@bda0aa0). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## hats #358 +/- ## ======================================= Coverage ? 93.40% ======================================= Files ? 49 Lines ? 1956 Branches ? 0 ======================================= Hits ? 1827 Misses ? 129 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.