search

astronomy-commons / hats

Hierarchical Progressive Survey Catalog
https://hats.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Add default column to properties #359

Closed delucchi-cmu closed 3 weeks ago

delucchi-cmu commented 3 weeks ago

Change Description

Closes #322 and #338

Adds the named property for default columns, for access in downstream applications.

Adds name checks for the full list of known properties, according to the current values in this spreadsheet.

Sneaks in a change to remove the two methods in write_metadata module. One is unused, and the other is a thin wrapper.

NB: This will cause some breaking changes in hipscat-import@hats. Fixing in branch https://github.com/astronomy-commons/hipscat-import/tree/issue/393/properties

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (hats@8db8e58). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/hats/catalog/dataset/table_properties.py 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## hats #359 +/- ## ======================================= Coverage ? 92.68% ======================================= Files ? 48 Lines ? 1954 Branches ? 0 ======================================= Hits ? 1811 Misses ? 143 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.