astronomy-commons / hats

Hierarchical Progressive Survey Catalog
https://hats.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Add custom healpix plotting method #374

Open smcguire-cmu opened 1 week ago

smcguire-cmu commented 1 week ago

Replaces healpy's plotting methods with a new healpix map plotting method based on mocpy's plotting functions.

Fixes #242

github-actions[bot] commented 1 week ago
Before [4357f0c9] After [a0d8ee37] Ratio Benchmark (Parameter)
13.3±0.2ms 13.8±0.5ms 1.04 benchmarks.Suite.time_inner_pixel_alignment
88.0±2ms 89.6±2ms 1.02 benchmarks.Suite.time_paths_creation
376±4ms 379±3ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
43.1±1ms 43.3±1ms 1.01 benchmarks.Suite.time_pixel_tree_creation
121±0.7ms 123±2ms 1.01 benchmarks.time_test_alignment_even_sky
76.9±0.3ms 76.5±0.4ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
971±4μs 967±7μs 1 benchmarks.time_test_cone_filter_multiple_order
76.9±0.2ms 75.9±1ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
20.1±0.5ms 19.3±0.4ms 0.96 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 94.78261% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.75%. Comparing base (5da4158) to head (89433b0). Report is 4 commits behind head on development.

Files with missing lines Patch % Lines
src/hipscat/inspection/visualize_catalog.py 95.53% 5 Missing :warning:
...hipscat/catalog/healpix_dataset/healpix_dataset.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #374 +/- ## =============================================== - Coverage 93.99% 93.75% -0.24% =============================================== Files 58 59 +1 Lines 2130 2241 +111 =============================================== + Hits 2002 2101 +99 - Misses 128 140 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hombit commented 4 days ago

@smcguire-cmu I played more! It gave me empty plot when I tried to do it for ALLWISE:

import hipscat

catalog = hipscat.loaders.read_from_hipscat('https://data.lsdb.io/unstable/wise/allwise')
hipscat.inspection.plot_points(catalog)
image

It also uses a lot of RAM, but it is probably expected?

Zoomed version works fine

import hipscat
from astropy.coordinates import Angle, SkyCoord

catalog = hipscat.loaders.read_from_hipscat('https://data.lsdb.io/unstable/wise/allwise')
hipscat.inspection.plot_points(catalog, center=SkyCoord(0, 0, unit='deg'), fov=(Angle(5, 'deg'), Angle(10, 'deg')))
image
hombit commented 4 days ago

@smcguire-cmu One more thing. It would be nice to make a "view window" to be a rectangle when fov is passed