astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Drop duplicates in leaf files during SOAP. #250

Closed delucchi-cmu closed 5 months ago

delucchi-cmu commented 5 months ago

Change Description

For most association between source-and-object, the two id values will be the same (since that's how we're finding the associations anyway). We don't need to keep those duplicate values around, and don't need to keep the source_id values around either.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.75%. Comparing base (ea60042) to head (be001bb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #250 +/- ## ======================================= Coverage 99.75% 99.75% ======================================= Files 24 24 Lines 1204 1204 ======================================= Hits 1201 1201 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.