Closed camposandro closed 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I built a small notebook showcasing the import process for MagE_hipscat
, the catalog in Julie's workflow. It reproduces the scenario where we run the pipeline at highest pixel order 2, stopping it during the reducing stage, and then proceeding to import the catalog at constant pixel order 3.
Attention: Patch coverage is 96.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 99.43%. Comparing base (
79b1af6
) to head (d0830da
).
Files | Patch % | Lines |
---|---|---|
src/hipscat_import/catalog/resume_plan.py | 96.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request closes #261.
Resolves the redundancy surrounding the
overwrite
/resume
import arguments, removingoverwrite
in favor ofresume
. Whenresume
is True (default) we attempt to read any intermediate files and continue the import pipeline from an earlier execution. If it is False, we delete any existing intermediate files, we reset the output directory, and start the pipeline from scratch.Resolves the issue of loading incompatible histogram binaries whenever trying to resume the import pipeline with a different HEALPix order. We now raise an error so that the user knows that they should set
resume=False
.[X] My PR includes a link to the issue that I am addressing
Code Quality