search

astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Use preferred string format for globbing. #291

Closed delucchi-cmu closed 2 months ago

delucchi-cmu commented 2 months ago

See https://github.com/astronomy-commons/lsdb/issues/294

See https://github.com/astronomy-commons/hipscat/pull/265

The "**" path part is only supported in the newest fsspec versions as an "entire path component", so it's ok to say /match/like/**/ but not /match/like/**.csv. This should work with older and newer fsspec versions, and so once the change is released for only newer fsspec versions, this package should be ok.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.35%. Comparing base (8b7975e) to head (e532cfb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #291 +/- ## ======================================= Coverage 99.35% 99.35% ======================================= Files 24 24 Lines 1238 1238 ======================================= Hits 1230 1230 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.