astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Use inferred member variable dictionary to create partition_info #304

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 2 months ago

Bug report

Currently, we create a dictionary for each InputReader type, that pulls in values from member variables.

We should, instead, automagically create a dictionary of parameter values from the object's members. This might only be feasible within dataclasses, but it might also work with plain-old-python-objects.

Before submitting Please check the following:

delucchi-cmu commented 2 months ago

Current code can cause errors when subclassing an existing input reader, but not accepting/initializing all expected super-class attributes in the sub-class.