astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Get all file_reader provenance info programmatically #316

Closed troyraen closed 1 month ago

troyraen commented 1 month ago

Change Description

Closes #304 Relies on astronomy-commons/hipscat#274

Updates the provenance_info method of the base class InputReader to return all class attributes. Removes the method from child classes.

This picks up attributes that were not previously being captured and results in some tests failing when the values cannot be json serialized. As far as I can tell, the best place to handle this is in hipscat.io.write_metadata.HipscatEncoder so I opened astronomy-commons/hipscat#274 to address it. Using that on my local machine, all tests pass.

Code Quality

Project-Specific Pull Request Checklists

Bug Fix Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.52%. Comparing base (80991e9) to head (c488194).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================== - Coverage 99.53% 99.52% -0.01% ========================================== Files 25 25 Lines 1284 1270 -14 ========================================== - Hits 1278 1264 -14 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.