Closed troyraen closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.52%. Comparing base (
80991e9
) to head (c488194
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Change Description
Closes #304 Relies on astronomy-commons/hipscat#274
Updates the
provenance_info
method of the base classInputReader
to return all class attributes. Removes the method from child classes.This picks up attributes that were not previously being captured and results in some tests failing when the values cannot be json serialized. As far as I can tell, the best place to handle this is in
hipscat.io.write_metadata.HipscatEncoder
so I opened astronomy-commons/hipscat#274 to address it. Using that on my local machine, all tests pass.Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist