astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Redact storage options, as this may include user keys. #322

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

The storage_options kwarg is very likely to contain sensitive user information, like API keys. Adds logic to suppress their storage in the provenance_info.json file.

Code Quality

Bug Fix Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.53%. Comparing base (e11308f) to head (85749f3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #322 +/- ## ======================================= Coverage 99.53% 99.53% ======================================= Files 25 25 Lines 1293 1296 +3 ======================================= + Hits 1287 1290 +3 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.