Enable std tqdm bar, refactor for re-use.

astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs

https://hipscat-import.readthedocs.io

BSD 3-Clause "New" or "Revised" License

5 stars 2 forks source link

Enable std tqdm bar, refactor for re-use. #330

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Closes #327.

Consolidates all tqdm calls into re-used print_progress method. This way, the simple_progress_bar argument will work the same for all pipeline types.

Code Quality

[x] I have read the Contribution Guide and LINCC Frameworks Code of Conduct
[x] My code follows the code style of this project
[x] My code builds (or compiles) cleanly without any errors or warnings
[x] My code contains relevant comments and necessary documentation

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.78%. Comparing base (c5e6095) to head (1899993). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #330 +/- ## ========================================== + Coverage 99.56% 99.78% +0.21% ========================================== Files 26 26 Lines 1379 1389 +10 ========================================== + Hits 1373 1386 +13 + Misses 6 3 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hombit commented 1 month ago

Should tqdm be also removed from the dependencies?

delucchi-cmu commented 1 month ago

Should tqdm be also removed from the dependencies?

No - we're still using the package, but we use different imports for different behavior (std out vs widget). The imports are still present in pipeline_resume_plan.py.