Closed delucchi-cmu closed 1 month ago
Attention: Patch coverage is 91.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 99.72%. Comparing base (
6c4451f
) to head (079f804
).
Files | Patch % | Lines |
---|---|---|
src/hipscat_import/catalog/run_import.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM. I think it will also be important to check this value against the number of rows in the parquet files directly at some point. In cases where the import process goes a little funky the parquet files can diverge from what was written in log files, and those are cases where this test can be especially valuable.
The method that writes out the parquet metadata will look at all of the footers for the parquet data files. https://github.com/astronomy-commons/hipscat/pull/306 will have that method return the total count. This would also be helpful for a few other import pipelines, where we read the footers AGAIN to calculate the total number of rows written. Once that PR is in, I'll update the code here to add the check.
Change Description
Closes #344
Solution Description
Adds a new argument,
expected_total_rows
, that users can specify if the total number of rows to be imported is known ahead of time. After the mapping stage, we check this against the total number of rows encountered.Using the result from the mapping stage, we also check the total for the scheduled reducing stage as well.
Code Quality