Margin generation improvements.

astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs

https://hipscat-import.readthedocs.io

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

Margin generation improvements. #356

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Use return value introduced in https://github.com/astronomy-commons/hipscat/pull/306
Add option to perform fine filtering. default behavior is same as current behavior.
Coarse pixel-level filtering now uses index-type filtering. Closes #353.
margin pair file doesn't write needless index, but does sort by margin_pixel, as we will query this value in the mapping stage

Code Quality

[x] I have read the Contribution Guide and LINCC Frameworks Code of Conduct
[x] My code follows the code style of this project
[x] My code builds (or compiles) cleanly without any errors or warnings
[x] My code contains relevant comments and necessary documentation

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.72%. Comparing base (ee02e32) to head (ab827c5).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #356 +/- ## ======================================= Coverage 99.72% 99.72% ======================================= Files 26 26 Lines 1456 1461 +5 ======================================= + Hits 1452 1457 +5 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.