astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Provide `drop_empty_siblings` argument #357

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Closes https://github.com/astronomy-commons/hipscat/issues/302 Closes #269

Solution Description

Adds drop_empty_siblings argument to binning calculation, as added in https://github.com/astronomy-commons/hipscat/pull/304.

Increases the default highest_order s.t. users are unlikely to need to change it, and clarifies behavior in the docstrings.

Code Quality

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.72%. Comparing base (8a34d62) to head (bd9eea8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ======================================= Coverage 99.72% 99.72% ======================================= Files 26 26 Lines 1454 1456 +2 ======================================= + Hits 1450 1452 +2 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.