astronomy-commons / hipscat-import

HiPSCat import - generate HiPSCat-partitioned catalogs
https://hipscat-import.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Distinguish error message for empty list vs None. #367

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Closes #341.

It's pretty common for users to use the result of a glob operation as input in the input_file_list argument. If the glob expression is mal-formed and the results are empty, they'll get a confusing error. This distinguishes the behavior from not passing in anything to hopefully give a more helpful message.

Code Quality

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.72%. Comparing base (28af48b) to head (46e1221).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #367 +/- ## ======================================= Coverage 99.72% 99.72% ======================================= Files 26 26 Lines 1457 1460 +3 ======================================= + Hits 1453 1456 +3 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.