Prepend file protocol to pointer

astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog

https://hipscat.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

14 stars 3 forks source link

Prepend file protocol to pointer #257

Closed camposandro closed 2 months ago

camposandro commented 2 months ago

Checks if a file path is complete (i.e. it is prefixed by the correct protocol) and prepends it if not.

[ ] My PR includes a link to the issue that I am addressing

Code Quality

[X] I have read the Contribution Guide
[X] My code follows the code style of this project
[X] My code builds (or compiles) cleanly without any errors or warnings
[X] My code contains relevant comments and necessary documentation

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.73%. Comparing base (10e527d) to head (5adde76).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 95.72% 95.73% ======================================= Files 56 56 Lines 1873 1875 +2 ======================================= + Hits 1793 1795 +2 Misses 80 80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Before [10e527db]	After [3fcff3f0]	Ratio	Benchmark (Parameter)
13.7±0.2ms	14.3±0.2ms	1.05	benchmarks.time_test_cone_filter_multiple_order
77.8±0.3ms	79.0±2ms	1.02	benchmarks.MetadataSuite.time_load_partition_join_info
44.7±1ms	45.6±1ms	1.02	benchmarks.Suite.time_pixel_tree_creation
20.6±0.4ms	20.7±0.6ms	1	benchmarks.MetadataSuite.time_load_partition_info_order6
79.4±2ms	79.6±2ms	1	benchmarks.MetadataSuite.time_load_partition_info_order7
124±1ms	124±0.5ms	1	benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.