astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Use nest ordering for point_map.fits file. #273

Closed delucchi-cmu closed 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Addresses #271 , but may not close the issue fully.

This change explicitly uses NESTED ordering in the healpix map stored as point_map.fits. For files written without an explicit ordering, the metadata indicates "RING". We throw a warning in this case, and just re-read the file using the older method.

Code Quality

Bug Fix Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.68%. Comparing base (251c13d) to head (1d3a740).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #273 +/- ## ========================================== + Coverage 93.66% 93.68% +0.01% ========================================== Files 57 57 Lines 1973 1979 +6 ========================================== + Hits 1848 1854 +6 Misses 125 125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago
Before [251c13d0] After [3acaaed0] Ratio Benchmark (Parameter)
80.3±2ms 81.3±2ms 1.01 benchmarks.Suite.time_paths_creation
122±1ms 123±0.5ms 1.01 benchmarks.time_test_alignment_even_sky
996±8μs 992±4μs 1 benchmarks.time_test_cone_filter_multiple_order
77.4±1ms 76.6±0.6ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
13.1±0.3ms 13.0±0.2ms 0.99 benchmarks.Suite.time_inner_pixel_alignment
362±4ms 359±2ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
39.5±1ms 39.3±2ms 0.99 benchmarks.Suite.time_pixel_tree_creation
18.3±0.4ms 18.0±0.08ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
77.7±0.5ms 76.5±0.2ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB