astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

Add catalog filter_by_moc method and replace spatial filters to use it #276

Closed smcguire-cmu closed 4 months ago

smcguire-cmu commented 4 months ago

Adds the filter_by_moc method to the HealpixDataset class and changes the spatial filter methods to use it. Adds the logic for performing a margin spatial filter to the MarginCatalog class.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.64%. Comparing base (5fdc4f6) to head (5d1b847). Report is 57 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ========================================== - Coverage 94.20% 93.64% -0.56% ========================================== Files 56 57 +1 Lines 1967 1968 +1 ========================================== - Hits 1853 1843 -10 - Misses 114 125 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago
Before [5fdc4f66] <v0.3.3> After [f44e5416] Ratio Benchmark (Parameter)
40.1±2ms 43.4±2ms 1.08 benchmarks.Suite.time_pixel_tree_creation
80.8±3ms 83.8±4ms 1.04 benchmarks.Suite.time_paths_creation
13.0±0.2ms 12.9±0.2ms 1 benchmarks.Suite.time_inner_pixel_alignment
361±2ms 361±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
78.1±0.6ms 77.4±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
19.6±0.3ms 19.2±0.5ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
77.8±0.9ms 76.6±0.5ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7
125±0.8ms 123±0.6ms 0.98 benchmarks.time_test_alignment_even_sky
13.6±0.04ms 997±3μs 0.07 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.