astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Derive `MarginCacheCatalogInfo` from `CatalogInfo` #285

Closed camposandro closed 1 month ago

camposandro commented 1 month ago

Adds the catalog specific metadata to the margin catalog info ("epoch", "ra" and "dec"). This enables the fine spatial filtering of margin catalogs when loaded separately from their primary catalogs. Related to https://github.com/astronomy-commons/lsdb/issues/308. Closes #286.

Code Quality

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.68%. Comparing base (d57f59c) to head (fb85774). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #285 +/- ## ======================================= Coverage 93.68% 93.68% ======================================= Files 57 57 Lines 1979 1979 ======================================= Hits 1854 1854 Misses 125 125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago
Before [696db00f] After [d28526d7] Ratio Benchmark (Parameter)
41.0±1ms 42.2±0.9ms 1.03 benchmarks.Suite.time_pixel_tree_creation
84.4±2ms 86.2±2ms 1.02 benchmarks.Suite.time_paths_creation
985±5μs 997±10μs 1.01 benchmarks.time_test_cone_filter_multiple_order
12.8±0.2ms 12.9±0.3ms 1 benchmarks.Suite.time_inner_pixel_alignment
124±0.6ms 124±0.3ms 1 benchmarks.time_test_alignment_even_sky
76.4±0.2ms 75.6±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
76.4±0.6ms 76.0±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
18.7±0.4ms 18.4±0.5ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
364±2ms 358±2ms 0.98 benchmarks.Suite.time_outer_pixel_alignment

Click here to view all benchmarks.