astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Fix smoke test, uses pathlib #290

Closed delucchi-cmu closed 3 weeks ago

delucchi-cmu commented 3 weeks ago

Change Description

Addresses smoke test failure.

There was an unfortunate merge combination with https://github.com/astronomy-commons/hipscat/pull/289 and https://github.com/astronomy-commons/hipscat/pull/288, where one uses os.path.join, and the other removes the import os statement. This updates to use pathlib for test path construction.

Code Quality

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.69%. Comparing base (b829115) to head (578c46f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== + Coverage 93.68% 93.69% +0.01% ========================================== Files 57 57 Lines 1979 1983 +4 ========================================== + Hits 1854 1858 +4 Misses 125 125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago
Before [a7338cab] After [5f9c710e] Ratio Benchmark (Parameter)
77.1±0.3ms 79.5±2ms 1.03 benchmarks.MetadataSuite.time_load_partition_info_order7
76.9±0.2ms 78.9±2ms 1.03 benchmarks.MetadataSuite.time_load_partition_join_info
123±0.8ms 126±0.4ms 1.02 benchmarks.time_test_alignment_even_sky
13.3±0.1ms 13.4±0.3ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
362±2ms 365±1ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
983±2μs 989±2μs 1.01 benchmarks.time_test_cone_filter_multiple_order
19.2±0.7ms 19.3±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
84.0±1ms 83.0±2ms 0.99 benchmarks.Suite.time_paths_creation
41.8±0.5ms 41.3±1ms 0.99 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.