astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

added support to url params on pixel_catalog_files #291

Closed Schwarzam closed 3 weeks ago

Schwarzam commented 3 weeks ago

This adds support to url query params to use for example with our parquet-server.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.80%. Comparing base (7b37616) to head (d261c8e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #291 +/- ## ========================================== + Coverage 93.69% 93.80% +0.10% ========================================== Files 57 57 Lines 1983 2002 +19 ========================================== + Hits 1858 1878 +20 + Misses 125 124 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago
Before [7b376161] After [678ddb25] Ratio Benchmark (Parameter)
18.6±0.5ms 19.7±0.6ms 1.06 benchmarks.MetadataSuite.time_load_partition_info_order6
40.0±1ms 41.4±1ms 1.04 benchmarks.Suite.time_pixel_tree_creation
77.1±0.5ms 77.6±0.4ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
364±2ms 366±5ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
77.5±1ms 77.7±0.5ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
84.2±2ms 84.3±2ms 1 benchmarks.Suite.time_paths_creation
123±0.9ms 122±0.6ms 0.99 benchmarks.time_test_alignment_even_sky
1.00±0.01ms 988±8μs 0.99 benchmarks.time_test_cone_filter_multiple_order
13.1±0.3ms 12.8±0.3ms 0.97 benchmarks.Suite.time_inner_pixel_alignment

Click here to view all benchmarks.

Schwarzam commented 3 weeks ago

Thank you very much for the reviews, i'm getting better on the code style conduct.