Closed delucchi-cmu closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.80%. Comparing base (
20eee15
) to head (ba2b4bc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before [20eee15e] | After [d7e87d21] | Ratio | Benchmark (Parameter) |
---|---|---|---|
991±2μs | 1.00±0.02ms | 1.01 | benchmarks.time_test_cone_filter_multiple_order |
79.7±0.5ms | 78.8±0.7ms | 0.99 | benchmarks.MetadataSuite.time_load_partition_join_info |
366±1ms | 363±2ms | 0.99 | benchmarks.Suite.time_outer_pixel_alignment |
43.6±0.7ms | 43.2±0.6ms | 0.99 | benchmarks.Suite.time_pixel_tree_creation |
22.6±0.3ms | 22.1±0.5ms | 0.98 | benchmarks.MetadataSuite.time_load_partition_info_order6 |
80.3±0.8ms | 78.5±0.8ms | 0.98 | benchmarks.MetadataSuite.time_load_partition_info_order7 |
13.9±0.2ms | 13.6±0.2ms | 0.98 | benchmarks.Suite.time_inner_pixel_alignment |
86.0±2ms | 84.1±2ms | 0.98 | benchmarks.Suite.time_paths_creation |
126±0.3ms | 123±1ms | 0.97 | benchmarks.time_test_alignment_even_sky |
Click here to view all benchmarks.
Change Description
Downstream projects that use mypy are sad about the new type hint on method.
See: https://github.com/astronomy-commons/lsdb/actions/runs/9486506921/job/26140991827?pr=354
Code Quality