astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

handle_pandas_storage_options #296

Open Schwarzam opened 2 weeks ago

Schwarzam commented 2 weeks ago

This PR closes #295.

Code Quality

New Feature Checklist

github-actions[bot] commented 2 weeks ago
Before [97643b63] After [2f793706] Ratio Benchmark (Parameter)
40.9±1ms 41.8±0.8ms 1.02 benchmarks.Suite.time_pixel_tree_creation
78.0±0.8ms 78.7±1ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
77.4±0.5ms 78.5±0.6ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
366±3ms 365±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
84.4±1ms 84.7±2ms 1 benchmarks.Suite.time_paths_creation
125±1ms 124±0.4ms 0.99 benchmarks.time_test_alignment_even_sky
997±8μs 988±6μs 0.99 benchmarks.time_test_cone_filter_multiple_order
13.5±0.3ms 13.2±0.1ms 0.98 benchmarks.Suite.time_inner_pixel_alignment
20.6±0.3ms 19.7±0.1ms 0.96 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.92%. Comparing base (3e1797c) to head (22cdc81). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================== + Coverage 93.80% 93.92% +0.11% ========================================== Files 57 58 +1 Lines 2002 2057 +55 ========================================== + Hits 1878 1932 +54 - Misses 124 125 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nevencaplar commented 2 days ago

@smcguire-cmu Can you please review this pull while Melissa is away.