astronomy-commons / hipscat

Hierarchical Progressive Survey Catalog
https://hipscat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Insert healpix shim over (most) healpy operations #297

Closed delucchi-cmu closed 2 weeks ago

delucchi-cmu commented 2 weeks ago

Change Description

Related to issue #53.

Creates a shim layer over (most) healpy calls. This will make the transition off healpy smoother for downstream packages, as we can consolidate the number of callsites for 3p healpix libraries. This also makes clear how many methods we require for full healpix support from non-healpy libraries.

Note that this doesn't provide a shim for any plotting functionality currently provided by healpy. This should instead be addressed via issue #242.

Code Quality

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.89%. Comparing base (3e1797c) to head (92b6093).

Files Patch % Lines
src/hipscat/pixel_math/healpix_shim.py 97.77% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #297 +/- ## ========================================== + Coverage 93.80% 93.89% +0.09% ========================================== Files 57 58 +1 Lines 2002 2048 +46 ========================================== + Hits 1878 1923 +45 - Misses 124 125 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago
Before [3e1797ce] After [47ea642a] Ratio Benchmark (Parameter)
failed 20.0±0.4ms n/a benchmarks.MetadataSuite.time_load_partition_info_order6
failed 77.8±0.3ms n/a benchmarks.MetadataSuite.time_load_partition_info_order7
failed 78.0±0.4ms n/a benchmarks.MetadataSuite.time_load_partition_join_info
failed 13.2±0.3ms n/a benchmarks.Suite.time_inner_pixel_alignment
failed 381±2ms n/a benchmarks.Suite.time_outer_pixel_alignment
failed 84.6±2ms n/a benchmarks.Suite.time_paths_creation
failed 42.0±0.6ms n/a benchmarks.Suite.time_pixel_tree_creation
failed 123±2ms n/a benchmarks.time_test_alignment_even_sky
failed 987±9μs n/a benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.