astronomy-commons / lsdb

Large Survey DataBase
https://lsdb.io
BSD 3-Clause "New" or "Revised" License
19 stars 5 forks source link

Remove code path for lsdb.read_hats to provide a margin object #473

Closed delucchi-cmu closed 2 weeks ago

delucchi-cmu commented 2 weeks ago

If the call to lsdb.read_hats(..., margin=margin_object) is used, it's possible (and easy) for the pre-loaded margin catalog to be inconsistent with the object catalog. It may have different columns, or have different spatial filters applied.

Initially, we'd been using a pattern of 1) load the margin catalog, and 2) pass the margin catalog to the primary catalog loading, but this is not intuitive for users, and it makes more sense to pass in the path and load both at the same time.