search

astronomy-commons / lsdb

Large Survey DataBase
https://lsdb.io
BSD 3-Clause "New" or "Revised" License
19 stars 5 forks source link

Remove margin object from `read_hats` #475

Closed camposandro closed 2 weeks ago

camposandro commented 2 weeks ago

Remove code path that allows to provide a margin object to read_hats. Adds a simple validation to make sure that the loaded margin has a compatible schema. Closes #473.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.67%. Comparing base (c9779aa) to head (fe09027). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #475 +/- ## ========================================== + Coverage 97.65% 97.67% +0.01% ========================================== Files 39 39 Lines 1537 1546 +9 ========================================== + Hits 1501 1510 +9 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago
Before [6888b52c] After [88227166] Ratio Benchmark (Parameter)
14.3±0.06s 14.8±0.02s 1.03 benchmarks.time_create_large_catalog
2.10±0.02s 2.17±0.03s 1.03 benchmarks.time_create_midsize_catalog
106±1ms 108±2ms 1.02 benchmarks.time_kdtree_crossmatch
18.6±0.4ms 18.7±0.5ms 1.01 benchmarks.time_box_filter_on_partition
33.3±0.9ms 32.8±1ms 0.99 benchmarks.time_polygon_search

Click here to view all benchmarks.