astronomy-commons / lsdb

Large Survey DataBase
https://lsdb.io
BSD 3-Clause "New" or "Revised" License
19 stars 5 forks source link

Test can be unskipped for column names with spaces #501

Closed delucchi-cmu closed 4 days ago

delucchi-cmu commented 4 days ago

lincc-frameworks/nested-pandas#174 has been closed.

Columns names which contain spaces and other special characters are now supported (even if they'd be weird).

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.66%. Comparing base (aaf065f) to head (d3a77d2). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #501 +/- ## ======================================= Coverage 97.66% 97.66% ======================================= Files 39 39 Lines 1540 1540 ======================================= Hits 1504 1504 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago
Before [aaf065f0] After [2cc871ec] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_polygon_search
16.1±0.4ms 17.3±0.3ms 1.07 benchmarks.time_box_filter_on_partition
99.7±0.9ms 105±0.9ms 1.05 benchmarks.time_kdtree_crossmatch
14.5±0.03s 14.6±0.05s 1.01 benchmarks.time_create_large_catalog
2.16±0.03s 2.16±0.02s 1.00 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.