astronomyk / PyReduce

GNU General Public License v3.0
1 stars 0 forks source link

Spectro Critical Algorithms Workplan #1

Open gijsverdoeskleijn opened 3 years ago

gijsverdoeskleijn commented 3 years ago

Dear all,

as promised during the meeting this morning, here are the links to the Github and Google Drive repositories:

REQUEST: Please tell me your github username so that I can add you as a collaborator to the github repo. (@Hugo, I know yours already)

Raw MICADO data from Wolgang (Google Drive):

https://drive.google.com/drive/folders/1s27bdRiBYmMWMIkjC1w9k9OaWD2mleb2?usp=sharing

@Wolfgang and Nadeen, please add/delete/update the data in here as you see fit

Github fork of PyReduce

https://github.com/astronomyk/PyReduce

To get the repo, simply clone it in the directory of choice on your local machine with

$ git clone https://github.com/astronomyk/PyReduce.git

The MICADO related files are found in the MICADO_info directory. These include:

Work plan

  1. [Nadeen, Wolfgang] - 3. Wavecal initial guess (micado.npz), details in issue https://github.com/astronomyk/PyReduce/issues/2
  2. [Wolfgang] - 2. Header keyword map (micado.json), details in https://github.com/astronomyk/PyReduce/issues/4
  3. [Hugo] A. Subclassing Instrument for MICADO (micado.py), details in issue https://github.com/astronomyk/PyReduce/issues/3
  4. [Nadeen] - 1. PyReduce runtime config file (settings_micado.json)
  5. [Nadeen] - B. PyReduce runtime script (micado_example.py)
  6. [Nadeen] - 4. Bad pixel mask FITS file (mask_micado.fits.gz)

Just to reiterate what was mentioned during the telecon, the highest priority item is the wavelength calibration initial guess (micado.npz). Everything else can(?) be "fudged" to get PyReduce up and running. I've added the Piskunov papers to the github repo, as these will surely be needed to work out what the data and format of the NPZ file should be.

Pyreduce Documentation

Just FYI, all the pyreduce documentation is still contained in the Github repo, so you need not constantly refer to the online docs. The doc page most relevant to us is the docs/instruments.rst page, as this contains the description of what columns need to be included in the wavecal (.npz) file

Fingers crossed this doesn't prove too difficult to implement.

Best regards, and best of luck to us all!

Kieran

gijsverdoeskleijn commented 3 years ago

@astronomyk, cc @hugobuddel : please give me the url of the github issue that will tackle "[Hugo, Kieran?] A. Subclassing Instrument for MICADO" and the hyperlink to the header keyword map that you sent to Wolfgang and Nadeen as starting point for "[Wolfgang] - 2. Header keyword map (micado.json)".

Anything you need from me?

hugobuddel commented 3 years ago

@astronomyk, cc @hugobuddel : please give me the url of the github issue that will tackle "[Hugo, Kieran?] A. Subclassing Instrument for MICADO" and the hyperlink to the header keyword map that you sent to Wolfgang and Nadeen as starting point for "[Wolfgang] - 2. Header keyword map (micado.json)".

Anything you need from me?

I've created https://github.com/astronomyk/PyReduce/issues/3 just now. It has the links to the draft micado.py and micado.json. The rest of micado.py we can discuss there.

astronomyk commented 3 years ago

Thanks hugo!!

Kieran Leschinski Department of Astrophysics University of Vienna

Am Mi., 9. Juni 2021 um 16:17 Uhr schrieb Hugo Buddelmeijer < @.***>:

@astronomyk https://github.com/astronomyk, cc @hugobuddel https://github.com/hugobuddel : please give me the url of the github issue that will tackle "[Hugo, Kieran?] A. Subclassing Instrument for MICADO" and the hyperlink to the header keyword map that you sent to Wolfgang and Nadeen as starting point for "[Wolfgang] - 2. Header keyword map (micado.json)".

Anything you need from me?

I've created #3 https://github.com/astronomyk/PyReduce/issues/3 just now. It has the links to the draft micado.py and micado.json. The rest of micado.py we can discuss there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/astronomyk/PyReduce/issues/1#issuecomment-857733394, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACH66QUPXM73KMXMC2DSYNDTR5ZXNANCNFSM46HH4WVQ .