search

astropy / SPISEA

Stellar Population Synthesis Modeling
https://spisea.readthedocs.io/en/stable/index.html
64 stars 32 forks source link

Resolved multiplicity edited #26

Closed nsabrams closed 4 years ago

nsabrams commented 4 years ago

I made the suggested edits including putting the functionality of the ResolvedCluster_ResolvedMult object into ResolvedCluster.

mwhosek commented 4 years ago

Looks great, thanks for implementing those changes! I was able to pull down your updated spisea code and everything appears to be working well.

I only have one final (and minor) comment, regarding your resolved_multiples_example.ipynb. I really like that you've included a jupyter notebook to demonstrate how it works, but I noticed that it has a dependence on the gcwork package. If a user doesn't have access to this package, then the first cell will fail. It doesn't look like you actually use the gcwork --> orbits in the notebook, so can it be removed?

Once this is addressed, we are ready to merge to dev.

nsabrams commented 4 years ago

I'll make the changes and resubmit. As discussed with Matt, I'll change the structure of the resolved clusters example to be in two sections so there aren't issues with importing gcworks