I suspect that the remove_bad_systems in the code for ResolvedCluster has a logical error inside of it due to how it does not account for the deletion of companions.
I suspect this since the body of the remove_bad_systems (Lines 411 - 444 in synthetic.py on the main branch of SPISEA) inspects neither directly nor indirectly whether masses of the companions are outside the range of masses provided by the isochrone. I further corroborate my suspicions with the observation that the _make_companions_table (Lines 273- 409 in synthetic.py on the main branch of SPISEA) does not handle the case where companions' IMF generated initial masses are less than the minimum mass of stars in the isochrone inputted to create the cluster.
I have spoken with Professor Lu around two weeks ago regarding this, and she seems to agree that this is a bit of an issue; I apologize for the delay. If we need to discuss more, I would be more than glad to discuss this on the Wednesday starclusters meeting.
Hello,
I suspect that the remove_bad_systems in the code for ResolvedCluster has a logical error inside of it due to how it does not account for the deletion of companions.
I suspect this since the body of the remove_bad_systems (Lines 411 - 444 in synthetic.py on the main branch of SPISEA) inspects neither directly nor indirectly whether masses of the companions are outside the range of masses provided by the isochrone. I further corroborate my suspicions with the observation that the _make_companions_table (Lines 273- 409 in synthetic.py on the main branch of SPISEA) does not handle the case where companions' IMF generated initial masses are less than the minimum mass of stars in the isochrone inputted to create the cluster.
I have spoken with Professor Lu around two weeks ago regarding this, and she seems to agree that this is a bit of an issue; I apologize for the delay. If we need to discuss more, I would be more than glad to discuss this on the Wednesday starclusters meeting.
Thanks, Ryota I.