astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
198 stars 109 forks source link

Move to APE 17 infrastructure and replace travis with github actions (Ready for review) #493

Closed mwcraig closed 3 years ago

mwcraig commented 3 years ago

This pull request will move astroplan from astropy-helpers to APE 17 (tox, setuptools_scm, etc.) and replaces Travis-CI with GitHub Actions.

Link to builds: https://github.com/mwcraig/astroplan/actions

This PR:

  1. Sets the minimum python version to 3.7
  2. Bumps the minimum versions for numpy and astropy
  3. Drops astropy helpers
  4. Switches from Travis-CI to GitHub actions

    To do:

mwcraig commented 3 years ago

@tepickering -- if you have some time to look at this that would be great. The only thing I had to do that there really seems like a better solution for are the links to the Astropy project that I changed in this commit: 27e8b633fe02217befdeed8e3b83257ddec5473b

That was the only way I found to avoid warnings that there was a duplicate reference.

tepickering commented 3 years ago

might it now be worth including python 3.9 in the test matrix? maybe just one test with default deps as a sanity check.

wtgee commented 3 years ago

Pinging @bmorris3 on a merge.

bmorris3 commented 3 years ago

Huge thanks to @mwcraig for putting this together and @wtgee and @tepickering for the thorough review.