astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
198 stars 109 forks source link

Adding MissingConstraintWarning warning #528

Closed bmorris3 closed 1 year ago

bmorris3 commented 1 year ago

This PR was originally meant to address #514 from @knservis, but it widened into a few overdue improvements.

New features: – A MissingConstraintWarning is raised when the user runs months_observable(constraints, ...) without an AltitudeConstraint or an AirmassConstraint among the constraints.

Improvements – better handling of nan times within astroplan – old manifest contents for astropy helpers are removed – a hidden method _process_nans_in_jds handles the masking of "bad" times uniformly across methods within the Observer class

Closes #514