astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
199 stars 109 forks source link

Removed redundancy between 'fmt' and 'linestyle' when using plot_date #530

Closed JAAlvarado-Montes closed 1 year ago

JAAlvarado-Montes commented 1 year ago

Dear Astropy Maintainers,

This PR intends to remove the redundancy and consequent Matplotlib UserWarning when using plot_date. In plot_date, fmt is set by default to 'o', so changing this to fmt='-' makes linestyle='-' redundant and produces a UserWarning advising of this redundancy. Such a warning is unnecessary and can be avoided if the line style_kwargs.setdefault('linestyle', '-') is removed, thus letting fmt to define the linestyle as desired.

With my best regards,

Jaime A. Alvarado-Montes

bmorris3 commented 1 year ago

Looks great, thanks @JAAlvarado-Montes!