search

astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
199 stars 109 forks source link

`Observable_interval` function added and `months_observable` aliased #531

Open tygger7 opened 1 year ago

tygger7 commented 1 year ago

Added a generic version months_observable called observable_interval. I also aliased months_observable to maintain backwards comparability, and help clean the code base. weeks_observable and days_observable aliases were also added; I felt it appropriate with months_observable remaining in the code. Lastly, I fixed a small issue with the "_current_year_time_range" as I noticed that it was not calculating visibility for December 31st in its current form.

Let me know if there is anything you think might need changed.

tygger7 commented 1 year ago

I have fixed the code style issues that were preventing check completion.

tygger7 commented 1 year ago

I have correct the issues that were indicated in the workflow.

bmorris3 commented 1 year ago

This is looking good. Could you please add tests for the new methods days_observable and weeks_observable?