search

astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
199 stars 109 forks source link

Enabled calculation of lunar and solar transit #532

Closed lunarspectrum closed 1 year ago

lunarspectrum commented 1 year ago

copied code from Observer._calc_riseset into ._calc_transit to enable calculations of lunar and solar transit.

bmorris3 commented 1 year ago

Hi @lunarspectrum, I've pushed a small improvement to your improvement. Rather than copying/pasting code to multiple places, I put the *Flag handling blocks in Observer.altaz, which seems more efficient.

lunarspectrum commented 1 year ago

Hi @bmorris3 , thanks for doing that. I copied it from the other location because I didn't have the full picture of dependencies and didn't want to break any other code. Much appreciated.

bmorris3 commented 1 year ago

Thanks so much for your first contribution! 🎉