search

astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3
https://astroplan.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
198 stars 109 forks source link

Observer.parallactic_angle uses LMST instead of LAST #534

Closed JSKenyon closed 1 year ago

JSKenyon commented 1 year ago

Whilst comparing various method of computing parallactic angle, I found that Observer.parallactic_angle always gives results which differ from e.g. python-casacore and skyfield. The major source of this discrepancy is that the underlying code makes use of Local Mean Sidereal Time (LMST) instead of Local Apparent Sidereal Time (LAST). Would it be possible to expose both the kind and model parameters in the interface to Oberserver.parallactic_angle?

bmorris3 commented 1 year ago

Hi @JSKenyon, certainly! There's a link above this comment to a pull request I just made which implements this feature request. I'll try to get tests passing and merge it ASAP. Thanks!

bmorris3 commented 1 year ago

The new requested feature has been implemented and merged in https://github.com/astropy/astroplan/pull/535! Thanks for this idea, @JSKenyon. 🎉

JSKenyon commented 1 year ago

Thanks for your quick response and fix @bmorris3!