Deprecation Warnings in observer.moon_rise_time()

astropy / astroplan

Observation planning package for astronomers – maintainer @bmorris3

https://astroplan.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

198 stars 109 forks source link

Deprecation Warnings in observer.moon_rise_time() #557

Closed dalerye closed 1 year ago

dalerye commented 1 year ago

The Astroplan functions observer.moon_rise_time() and observer.moon_set_time() apparently call the Astroplan function get_moon(), which is now deprecated in favor of get_body("moon"). As a result, every call to the Astroplan functions now generates a deprecation warning in the output. Are there plans to fix this, or is there some other way to easily calculate moon rise and set times in Astroplan?

bmorris3 commented 1 year ago

Hi @dalerye, there's a fix in https://github.com/astropy/astroplan/pull/558. I'll merge that as soon as the tests pass. Thanks for the heads up!